feat: support all address types by ben-kaufman · Pull Request #431 · synonymdev/bitkit-ios

ben-kaufman · 2026-02-05T11:13:12Z

This PR adds support for multiple Bitcoin address types in the iOS app, allowing users to select and monitor different address formats. Users can select their preferred address type from: Legacy (P2PKH), Nested SegWit (P2SH-P2WPKH), Native SegWit (P2WPKH), and Taproot (P2TR).

This requires extensive testing across all functionalities, send, receive, channel open, channel close (funds should always go to native segwit address except when selected address when channel opened was Taproot, in which case it should be a Taproot address), cpfp, rbf. All should be checked for each address type, and for multiple address types combined (ie. send with utxos of different address types, open channel with inputs of different address types, boost txs with inputs of different address types, etc.)

jvsena42

Found one last issue

nit: could disable the swich option while the switching is in progress

1. Address Type Selection & Settings

Initial Setup

Fresh wallet creation - verify default address type is Native SegWit
Navigate to Settings → Advanced → Address Type Preference
Verify all 4 address types are displayed with correct labels:
- Legacy (1x...)
- Nested SegWit (3x...)
- Native SegWit (bc1q...)
- Taproot (bc1p...)

Switching Address Types

Switch from Native SegWit to Legacy - verify success toast
Verify receive address changes to Legacy format (starts with "m" for regtest)
Switch to Nested SegWit - verify address starts with "2" for regtest
Switch to Taproot - verify address starts with "bcrt1p" for regtest
Switch back to Native SegWit - verify address starts with "bcrt1q" for regtest

Monitored Address Types (Dev Settings)

Enable dev settings and verify "Monitored Address Types" section appears
Enable monitoring for Legacy while Native SegWit is selected
Enable monitoring for Taproot while Native SegWit is selected
Verify cannot disable currently selected address type
Verify cannot disable last native witness type (Native SegWit or Taproot)
Add funds to a monitored type, then try to disable it - should fail

2. Receive Functionality

Address QR Codes

Generate QR code for each address type
Verify QR code contains correct address format
Test scanning generated QR codes

Multiple Address Types (Mixed Wallet)

Set address type to Native SegWit, receive funds
Switch to Legacy, receive funds to new Legacy address
Switch to Taproot, receive funds to new Taproot address
Verify all balances are correctly aggregated in wallet total
Verify activity list shows all transactions

3. Send Functionality

Single Address Type Sends

Enable manual coin selection
Add tags to identify the address type
Legacy only: Send from wallet selecting only Legacy UTXOs
- Verify fee estimation
- Complete send and verify transaction
Nested SegWit only: Send from wallet selecting only Nested SegWit UTXOs
Native SegWit only: Send from wallet selecting only Native SegWit UTXOs
Taproot only: Send from wallet selecting only Taproot UTXOs

4. Lightning Channel Operations

Channel Opening

Legacy: Set address type to Legacy, open channel
- Verify funding transaction uses Legacy inputs if available
Nested SegWit: Set to Nested SegWit, open channel
- Verify funding transaction format
Native SegWit: Set to Native SegWit, open channel
Taproot: Set to Taproot, open channel
Mixed UTXOs: Open channel with inputs from multiple address types

5. Fee Bumping (RBF - Replace-By-Fee)

RBF Single Address Type

Send replaceable transaction from Legacy wallet, bump fee
Send replaceable transaction from Nested SegWit wallet, bump fee
Send replaceable transaction from Native SegWit wallet, bump fee
Send replaceable transaction from Taproot wallet, bump fee

RBF Mixed Address Types

Send transaction with all 4 address types, bump fee

6. CPFP (Child-Pays-For-Parent)

CPFP Single Address Type

Receive unconfirmed transaction to Legacy address, boost with CPFP
Receive unconfirmed transaction to Nested SegWit, boost with CPFP
Receive unconfirmed transaction to Native SegWit, boost with CPFP
Receive unconfirmed transaction to Taproot, boost with CPFP

7. Wallet Restore & Migration

Fresh Restore

Restore wallet with funds across all 4 address types
- Verify all funds are discovered and aggregated correctly

Migration from React Native App

Verify address type migration handles properly (RN only allowed select taproot and native segwit)
Check monitored types are correctly configured after migration

8. Balance & Display

Balance Calculation

Verify total balance correctly sums all address types
Verify spendable balance is accurate with mixed UTXOs
Check balance per address type (dev settings)

Activity List

Verify transactions from all address types appear in activity list
Verify correct icons/labels for each address type transaction
Test filtering/sorting with mixed address type transactions

9. Edge Cases & Error Handling

Settings Validations

Try to disable all monitored types - should fail
Try to disable currently selected type - should fail
Try to disable last native witness type - should fail

10. Backup & Security

Backup Flows

Create backup after switching address types
❌ Restore from backup - verify address type preferences are preserved - #431 (comment)
Verify seed phrase backup includes all address types

ben-kaufman · 2026-02-23T16:10:59Z

@jvsena42 fixed the issues with restore and switch not disabled

jvsena42

tAck

ovitrif · 2026-02-25T13:06:29Z

PLS find resolution for all comments (must be "resolved"): either fix here or create issue to fix/address later.

Also, once ready for final pass (review+approve) it's needed to re-request review of all reviews which requested changes:

pwltr · 2026-02-25T13:48:01Z

PLS find resolution for all comments (must be "resolved"): either fix here or create issue to fix/address later.

Those we're just comments, not change requests. Not sure why GH requires them to be resolved. Approving now.

piotr-iohk · 2026-02-26T15:03:13Z

Could be the same/similar issue as here (synonymdev/bitkit-android#788 (comment)) but manifesting a bit differently. When trying to transfer max (in case when I have 25k on each address) sometimes I am not able to swipe to transfer (the GRAB element is locked, cannot be dragged). Note that transfering smaller amounts seems to work. Perhaps some coins selection fails in the background?

bitkit_logs_2026-02-26_14-52-13.zip

Screen.Recording.2026-02-26.at.15.47.05.mov

piotr-iohk · 2026-02-27T14:32:19Z

Encountered the issue again today (on revision d0cd7b6).

This time the spinner was spinning inifinitely after "dragging to transfer".
In the logs there is:

bitkit_logs_2026-02-27_12-57-14.zip

[2026-02-27 12:46:29.840 UTC] ERROR❌: Coin selection failed: Coin selection failed - [LDK] [ldk_node::wallet:922] [Logger.swift: log(record:) line: 177]
[2026-02-27 12:46:29.841 UTC] ERROR❌: Coin selection failed [Coin selection failed to find suitable UTXOs.] - ldk-node error [Errors.swift: init(ldkError:) line: 416]
[2026-02-27 12:46:29.841 UTC] ERROR❌: Coin selection failed [Coin selection failed to find suitable UTXOs.] - ServiceQueue: ldk [ServiceQueue.swift: background(_:_:functionName:) line: 51]
[2026-02-27 12:46:29.841 UTC] INFOℹ️: Normal coin selection failed, using sendAll: AppError(message: "Coin selection failed", debugMessage: Optional("Coin selection failed to find suitable UTXOs.")) [SpendingConfirm.swift: calculateTransactionFee() line: 214]
[2026-02-27 12:46:29.841 UTC] ERROR❌: Selected UTXOs have insufficient value. Have: 100000sats, Need at least: 101000sats - [LDK] [ldk_node::wallet:978] [Logger.swift: log(record:) line: 177]

piotr-iohk · 2026-02-27T18:10:20Z

Similarly to synonymdev/bitkit-android#788 (comment)

each address funded with 10k = 40k total balance
send out 39k. (here it sends 40k not leaving dust, dust added to recipient)
trying to rbf such transaction = getting Toast error: "Bitkit was not able to boost"

bitkit_logs_2026-02-27_18-05-30.zip

ben-kaufman · 2026-02-28T00:34:53Z

Makes sense though since you cannot RBF without having sufficient change or extra funds, so looks like correct behavior no?

piotr-iohk · 2026-03-02T13:27:07Z

Similar as in Android (synonymdev/bitkit-android#788 (comment)), however here the legacy balance is not included when setting up external channel and trying to send max, however I guess the issue may be the fees?

each address has 25k
opening external channel sending max = 75k (legacy balance not included)
toast error: "Timeout waiting for channel pending event"

bitkit_logs_2026-03-02_13-25-07.zip

Screen.Recording.2026-03-02.at.14.23.04.mov

…nonymdev/bitkit-ios into feat/multiple-addresses-types

ben-kaufman · 2026-03-02T15:38:08Z

@piotr-iohk updated

ben-kaufman requested a review from ovitrif February 5, 2026 11:13

This comment has been minimized.

Sign in to view

ben-kaufman force-pushed the feat/multiple-addresses-types branch from 919e450 to 8c8e243 Compare February 11, 2026 04:38

This comment has been minimized.

Sign in to view

ben-kaufman requested review from jvsena42 and pwltr February 12, 2026 05:15

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

ben-kaufman added 17 commits February 16, 2026 21:09

feat: support all address types

75dc541

Fix legacy type issues

36c600e

Update ldk-node

32a3ba6

fix balance check on disable

4cab166

fix timeout issue

82cf9ad

fix

13b8ab4

fix multiple address support for backup and migration

9ac4142

remove funds sweep for different address types

bff806b

fixes

8ca8c88

update ldk-node

b85158f

update ldk-node

4181b50

update ldk node

6502cb3

fix wipe and update comments

cd23f7d

fixes

184d32d

extract texts

6f448f0

remove empty wallets from monitor list after restore

dcb9dc6

add tests

b0e40c3

This comment was marked as resolved.

Sign in to view

jvsena42 requested changes Feb 23, 2026

View reviewed changes

fix restore issues

5ff7d51

jvsena42 previously approved these changes Feb 23, 2026

View reviewed changes

Update ldk-node

b77ba6f

ben-kaufman dismissed jvsena42’s stale review via b77ba6f February 25, 2026 06:26

Merge branch 'master' into feat/multiple-addresses-types

481e477

pwltr self-requested a review February 25, 2026 13:47

pwltr previously approved these changes Feb 25, 2026

View reviewed changes

jvsena42 previously approved these changes Feb 25, 2026

View reviewed changes

fix transfer max

d0cd7b6

ben-kaufman dismissed stale reviews from jvsena42 and pwltr via d0cd7b6 February 27, 2026 00:29

ben-kaufman mentioned this pull request Feb 28, 2026

feat: support all address types synonymdev/bitkit-android#788

Open

ben-kaufman added 2 commits March 2, 2026 08:10

fix: use dedicated send-all fee estimation for near-max transfers

9b4e402

Merge branch 'master' into feat/multiple-addresses-types

1a28d9b

ovitrif requested a review from piotr-iohk March 2, 2026 10:15

piotr-iohk and others added 4 commits March 2, 2026 14:28

add missing test ids

ca9bcc5

Merge branch 'master' into feat/multiple-addresses-types

70457e1

fix max amount for channel open

201817b

Merge branch 'feat/multiple-addresses-types' of https://github.com/sy…

bccb5fe

…nonymdev/bitkit-ios into feat/multiple-addresses-types

Conversation

ben-kaufman commented Feb 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as resolved.

jvsena42 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

1. Address Type Selection & Settings

Initial Setup

Switching Address Types

Monitored Address Types (Dev Settings)

2. Receive Functionality

Address QR Codes

Multiple Address Types (Mixed Wallet)

3. Send Functionality

Single Address Type Sends

4. Lightning Channel Operations

Channel Opening

5. Fee Bumping (RBF - Replace-By-Fee)

RBF Single Address Type

RBF Mixed Address Types

6. CPFP (Child-Pays-For-Parent)

CPFP Single Address Type

7. Wallet Restore & Migration

Fresh Restore

Migration from React Native App

8. Balance & Display

Balance Calculation

Activity List

9. Edge Cases & Error Handling

Settings Validations

10. Backup & Security

Backup Flows

Uh oh!

ben-kaufman commented Feb 23, 2026

Uh oh!

jvsena42 left a comment

Choose a reason for hiding this comment

Uh oh!

ovitrif commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pwltr commented Feb 25, 2026

Uh oh!

piotr-iohk commented Feb 26, 2026

Uh oh!

piotr-iohk commented Feb 27, 2026 • edited by ovitrif Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

piotr-iohk commented Feb 27, 2026

Uh oh!

ben-kaufman commented Feb 28, 2026

Uh oh!

piotr-iohk commented Mar 2, 2026

Uh oh!

ben-kaufman commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jvsena42 left a comment •

edited

Loading

ovitrif commented Feb 25, 2026 •

edited

Loading

piotr-iohk commented Feb 27, 2026 •

edited by ovitrif

Loading